Skip to content

Add Configured condition to Syslog controller - #685

Merged
felix-kaestner merged 1 commit into
ironcore-dev:mainfrom
lparz1val:feat/configured-condition-syslog
Oct 26, 2026
Merged

felix-kaestner merged 1 commit into
ironcore-dev:mainfrom
lparz1val:feat/configured-condition-syslog

Conversation

@lparz1val

Copy link
Copy Markdown
Contributor

Adds a Configured condition to the Syslog controller, following the pattern introduced for Banner (#426). Removes the old type-rename hack that set a Configured-flavored condition directly on Ready.

Changes:

  • syslog_types.go — add Configured print column (priority=1)
  • syslog_controller.go — InitializeConditions adds ConfiguredCondition; deferred RecomputeReady; removed type-rename hack; EnsureSyslog result sets Configured directly
  • syslog_controller_test.go — 2 → 3 conditions in happy-path assertion
  • Regenerated CRD and Helm chart

Testing

make vet lint test test-gnmi all pass.

Verified live against cisco1 (nx.cisco) on kind dev cluster:

NAME               DEVICE   SERVERS    READY   CONFIGURED   PAUSED   AGE
syslog-live-test   cisco1   1 server   True    True         False    49s
status:
  conditions:
  - lastTransitionTime: "2026-10-26T08:32:41Z"
    message: All conditions are ready
    reason: Ready
    status: "True"
    type: Ready
  - lastTransitionTime: "2026-10-26T08:33:22Z"
    message: Configured successfully
    reason: Configured
    status: "True"
    type: Configured
  - lastTransitionTime: "2026-10-26T08:32:39Z"
    message: ""
    reason: NotPaused
    status: "False"
    type: Paused
  serversSummary: 1 server

Signed-off-by: Yurii Levchenko <yurii.levchenko@sap.com>
@felix-kaestner
felix-kaestner enabled auto-merge (rebase) October 26, 2026 12:16
@felix-kaestner
felix-kaestner merged commit 9de8242 into ironcore-dev:main Oct 26, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants