Repository navigation
Add Configured condition to User controller - #686
Merged
felix-kaestner merged 1 commit intoOct 26, 2026
Merged
Conversation
Signed-off-by: Yurii Levchenko <yurii.levchenko@sap.com>
felix-kaestner
approved these changes
Oct 26, 2026
felix-kaestner
enabled auto-merge (rebase)
October 26, 2026 12:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
Configuredcondition to the User controller, following the pattern introduced for Banner (#426). Removes the old type-rename hack that set aConfigured-flavored condition directly onReady. Theclientutil.NewClientSecret fetch path correctly does not setConfigured— K8s API errors say nothing about device config state.Changes:
user_types.go— addConfiguredprint column (priority=1)user_controller.go—InitializeConditionsaddsConfiguredCondition; deferredRecomputeReady; removed type-rename hack;EnsureUserresult setsConfigureddirectlyuser_controller_test.go— 2 → 3 conditions in happy-path assertionTesting
make vet lint test test-gnmiall pass.Verified live against
cisco1(nx.cisco) on kind dev cluster: