Skip to content

Fix Configured condition assertion in BGP controller test - #691

Merged
adamtrizuljak-sap merged 1 commit into
mainfrom
fix/bgp-redistribute-static-test-condition
Oct 28, 2026
Merged

adamtrizuljak-sap merged 1 commit into
mainfrom
fix/bgp-redistribute-static-test-condition

Conversation

@adamtrizuljak-sap

Copy link
Copy Markdown
Contributor

#682 implemented ConfiguredCondition in the BGP controller. After rebasing #662, I forgot to change ReadyCondition to ConfiguredCondition in BGP controller tests

Signed-off-by: Adam Trizuljak <adam.trizuljak@sap.com>
@github-actions

Copy link
Copy Markdown

Caution

No coverage for base commit a35238f was found, so this report compares against its ancestor 10cc35f (5 commits earlier)

Merging this branch changes the coverage (5 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/internal/controller/cisco/nx 64.97% (-0.35%) 👎
github.com/ironcore-dev/network-operator/internal/controller/core 62.28% (+0.02%) 👍
github.com/ironcore-dev/network-operator/internal/controller/evpn 79.70% (-0.90%) 👎
github.com/ironcore-dev/network-operator/internal/controller/overlay 66.36% (-4.55%) 👎
github.com/ironcore-dev/network-operator/internal/controller/pool 72.15% (-1.90%) 👎
github.com/ironcore-dev/network-operator/internal/provider/openconfig 9.51% (-0.03%) 👎
Coverage details

Compared to commit 10cc35f (run #40321897417)

Changed unit test files:

  • github.com/ironcore-dev/network-operator/internal/controller/core/bgp_controller_test.go

@adamtrizuljak-sap
adamtrizuljak-sap merged commit ccc7dbf into main Oct 28, 2026
26 checks passed
@adamtrizuljak-sap
adamtrizuljak-sap deleted the fix/bgp-redistribute-static-test-condition branch October 28, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants