Skip to content

Address PR #3 review comments: fix error handling, remove dead code, add type annotations#5

Draft
ferferga with Copilot wants to merge 3 commits into
mainfrom
copilot/add-type-information-python-modules
Draft

Address PR #3 review comments: fix error handling, remove dead code, add type annotations#5
ferferga with Copilot wants to merge 3 commits into
mainfrom
copilot/add-type-information-python-modules

Conversation

Copilot AI commented Jan 27, 2026

Copy link
Copy Markdown

Addresses unresolved comments from PR #3 review and completes type annotations across all Python modules.

Error Handling

  • All extraction phases (GraphQL, Releases, Commits, Workflows) now consistently set errors_occurred flag on failure
  • Prevents incomplete data from being exported when any extraction phase fails

Code Cleanup

  • Removed unused ATTR_TYPES constant in builder.py
  • Removed dead code: _map_comments() function (defined but never called)

Documentation

Added explanatory comments for design decisions:

  • Type conversion: OCEL 2.0 requires string values; type validation happens at schema level
  • Timestamp handling: Object attributes use current time per OCEL 2.0 spec; UTC assumption for 'Z' suffix append
  • N+1 pattern: fetch_commits_rest() documents acceptable performance tradeoff given API constraints

Type Annotations

  • Completed return type annotations: main(), validate_ocel(), get_logger()
  • Fixed duplicate Union import in validate_ocel.py

All modules now have complete type information for static analysis tools.

Original prompt

@copilot open a new pull request to apply changes based on the comments in this thread. Ignore the changes that have been already applied in main. Add type information to all the Python modules where no typing information is provided.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits January 27, 2026 15:58
…ode, add documentation

Co-authored-by: ferferga <10274099+ferferga@users.noreply.github.com>
Co-authored-by: ferferga <10274099+ferferga@users.noreply.github.com>
Copilot AI changed the title [WIP] Add type information to Python modules without typing Address PR #3 review comments: fix error handling, remove dead code, add type annotations Jan 27, 2026
Copilot AI requested a review from ferferga January 27, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants