Skip to content

Commit 6131a57

Browse files
authored
Fixes SB3's template ppo cfg up to date with security-safe syntax for training specification (#3688)
# Description This PR fixes the bug where if template is generated using SB3, the code does not run because it couldn't parse from string ``` policy_kwargs: "dict( activation_fn=nn.ELU, net_arch=[32, 32], squash_output=False, )" ``` We have disabled the string parsing, as it is not safe(aka arbitrary code could be parsed) this PR makes sure the sb3's template also adopt the new secure syntax ``` policy_kwargs: activation_fn: nn.ELU net_arch: [32, 32] squash_output: False ``` ## Checklist - [x] I have read and understood the [contribution guidelines](https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
1 parent f52aa98 commit 6131a57

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

tools/template/templates/agents/sb3_ppo_cfg

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,10 @@ n_epochs: 20
1111
ent_coef: 0.01
1212
learning_rate: !!float 3e-4
1313
clip_range: !!float 0.2
14-
policy_kwargs: "dict(
15-
activation_fn=nn.ELU,
16-
net_arch=[32, 32],
17-
squash_output=False,
18-
)"
14+
policy_kwargs:
15+
activation_fn: nn.ELU
16+
net_arch: [32, 32]
17+
squash_output: False
1918
vf_coef: 1.0
2019
max_grad_norm: 1.0
2120
device: "cuda:0"

0 commit comments

Comments
 (0)