revert: remove CP toast notification on decrypt failure#7
Merged
Conversation
The toast delivery proved unreliable across all tested paths: - AddToasts/Axios interceptor path fails on page refresh because Listing.vue's AbortController cancels the first request after the server has already consumed the dedup cache key, so the second (actually-read) response carries no _toasts. - session()->flash() path shows only on the subsequent page load and produced confusing UX. Remove all associated code and tests: - Drop Toast, Cache, Statamic imports and NOTIFY_TTL constant from FieldEncryptor; decrypt() now just logs a warning and returns the raw value on failure. - Remove the $context parameter from decrypt() and update both repository callers. - Remove the decrypt_failure_toast lang string. - Remove two now-stale FieldEncryptorTest cases (they tested absence of Toast calls, which passed trivially after the code was gone). - Update OVERVIEW.md and PLAN.md to reflect the simplified behaviour. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
andrii-trush
force-pushed
the
feature/cp-toast-decrypt-failure
branch
from
33d4961 to
91b2baa
Compare
Member
Author
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Listing.vue'sAbortControllercancels the first request after the server has already consumed the dedup cache key — so the second (actually-read) response carries no_toasts. Thesession()->flash()fallback only appeared on the next page load and produced confusing UX (showed a toast saying literally "error" due to a separate message bug).FieldEncryptor::decrypt()now simply logs aLog::warningand returns the raw ciphertext on failure — no side-effects.$contextparameter fromdecrypt()and updated both repository callers.decrypt_failure_toastlang string, theNOTIFY_TTLconstant, and all related imports (Toast,Cache,Statamic,session).FieldEncryptorTestcases that asserted the absence ofToast::error()calls — they passed trivially once the code was gone.OVERVIEW.mdandPLAN.mdto reflect the simplified behaviour.