Bug fixes #15
Merged
Bug fixes #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, I have 3 changes.
Auto mode bug: A second if statement in the joystick callback would cause the drive_mode parameter to toggle from manual to auto, back to manual. As it only exists in the example code, it's not terribly important.
In the lms1xx launch file, the node pkg was left as lms1xx, when the enclosing package is actually isc_sick.
Our sick's reported range is from -45 to 225 degrees. ROS convention dictates that the 0 angle should be aligned with robot's forward facing axis (positive x, generally), but the sick's range would consider forward to be 90 degrees. I believe a similar problem was reported here. Since it only matters for TF, I added it as a parameter that overrides current behavior, but keeps the current behavior as default.