Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/oph24 16 registration page #10

Merged
merged 48 commits into from
Jan 7, 2024
Merged

Conversation

VorraphanT
Copy link
Contributor

@VorraphanT VorraphanT commented Dec 22, 2023

Change made

  • Bug fixes
  • New features
  • Breaking changes

Describe what you have done

New Features

Fix

Others

@shalluv
Copy link
Member

shalluv commented Dec 23, 2023

แนะนำว่าไม่ต้องใช้ทุกไฟล์เป็น .astro ก็ได้นะ แบบลองดูว่าตรงไหนเป็น interactive แบบ user กด ๆ ได้ไรงี้ ก็ใช้ react ก็ได้

@shalluv shalluv self-requested a review December 23, 2023 07:50
@shalluv shalluv marked this pull request as draft December 23, 2023 07:51
@shalluv
Copy link
Member

shalluv commented Dec 27, 2023

Please rename the components to make them more readable. Using numbered labels makes it difficult to understand the purpose of each component.

@shalluv shalluv marked this pull request as ready for review January 3, 2024 15:13
@shalluv shalluv merged commit 58446c7 into dev Jan 7, 2024
1 check passed
@shalluv shalluv deleted the feature/oph24-16-registration-page branch January 7, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants