Quickfix x86 builds #2129
Open
Quickfix x86 builds #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inked with either.
|
2129 |
|
|
This 2 file changed was that on the ish shell ? |
TichThong
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small patch for the time being until the build environment gets rewritten. I attempted to have
EXCLUDED_ARCHSset from the xcconfig, but it just wouldn't take and I'd still get issues when it'd try cross compiling the arm64 build. I've left a comment about that unless there's another way of getting the following line to work:This is all under the assumption that universal builds just won't make the cut for iSH.