Skip to content

Commit

Permalink
Implement GroupImpl::Unknown (71.63%)
Browse files Browse the repository at this point in the history
  • Loading branch information
madebr committed Dec 20, 2024
1 parent 459ddf2 commit a942195
Show file tree
Hide file tree
Showing 3 changed files with 58 additions and 5 deletions.
56 changes: 53 additions & 3 deletions LEGO1/tgl/d3drm/group.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,58 @@ Result GroupImpl::RemoveAll()
return Error;
}

// STUB: LEGO1 0x100a3540
Result GroupImpl::Unknown()
// FUNCTION: LEGO1 0x100a3540
Result GroupImpl::Bounds(D3DVECTOR *p_min, D3DVECTOR *p_max)
{
return Error;
D3DRMBOX size;
IDirect3DRMFrame2 *frame = m_data;
size.min.x = 88888.f;
size.min.y = 88888.f;
size.min.z = 88888.f;
size.max.x = -88888.f;
size.max.y = -88888.f;
size.max.z = -88888.f;
IDirect3DRMVisualArray *visuals;
Result result = (Result) SUCCEEDED(frame->GetVisuals(&visuals));
if (result) {
int i;
for (i = 0; i < (int)visuals->GetSize(); i++) {
IDirect3DRMVisual *visual;
visuals->GetElement(i, &visual);
IDirect3DRMMesh *mesh;
/*
* BUG: should be:
* visual->QueryInterface(IID_IDirect3DRMMesh, (void**)&mesh));
*/
result = (Result) SUCCEEDED(visual->QueryInterface(IID_IDirect3DRMMeshBuilder, (void**)&mesh));
if (result) {
D3DRMBOX box;
result = (Result) SUCCEEDED(mesh->GetBox(&box));
if (size.max.y < box.max.y) {
size.max.y = box.max.y;
}
if (size.max.z < box.max.z) {
size.max.z = box.max.z;
}
if (box.min.x < size.min.x) {
size.min.x = box.min.x;
}
if (box.min.y < size.min.y) {
size.min.y = box.min.y;
}
if (box.min.z < size.min.z) {
size.min.z = box.min.z;
}
if (size.max.x < box.max.x) {
size.max.x = box.max.x;
}
mesh->Release();
}
visual->Release();
}
visuals->Release();
}
*p_min = size.min;
*p_max = size.max;
return result;
}
5 changes: 4 additions & 1 deletion LEGO1/tgl/d3drm/impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ class GroupImpl : public Group {
Result RemoveAll() override;

// vtable+0x30
Result Unknown() override;
Result Bounds(D3DVECTOR *p_min, D3DVECTOR *p_max) override;

IDirect3DRMFrame2* ImplementationData() const { return m_data; }

Expand Down Expand Up @@ -545,4 +545,7 @@ inline D3DRMMATRIX4D* Translate(FloatMatrix4& tglMatrix4x4, D3DRMMATRIX4D& rD3DR
// SYNTHETIC: LEGO1 0x100a3d80
// TglImpl::MeshImpl::`scalar deleting destructor'

// GLOBAL: LEGO1 0x100dd1e0
// IID_IDirect3DRMMeshBuilder

} /* namespace TglImpl */
2 changes: 1 addition & 1 deletion LEGO1/tgl/tgl.h
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ class Group : public Object {

// This is TransformLocalToWorld in the leak, however it seems
// to have been replaced by something else in the shipped code.
virtual Result Unknown() = 0;
virtual Result Bounds(D3DVECTOR *, D3DVECTOR *) = 0;

// SYNTHETIC: LEGO1 0x100a2510
// Tgl::Group::~Group
Expand Down

0 comments on commit a942195

Please sign in to comment.