Progress on Helicopter::FUN_100042a0
#1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I gave it a shot and improved the match to about ~60%. Still not 100% sure if the logic is completely correct but I think it's closer. Unfortunately the compiler optimizes the vectors a lot and Ghidra isn't particularly helpful with this function. We can leave this open for a while in case someone else wants to give it a try. |
|
Actually I think we got somewhere - replaced the |
|
Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my progress in case someone wants to continue. I am a bit stuck.
On the bright side, there may be a non-inlined version of
UnknownMx4DPointFloat::Unknown7()here, where I improved the match. I didn't check the impact on other parts of the code yet.