Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GroupImpl::RemoveAll #1244

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Implement GroupImpl::RemoveAll #1244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7eb52b1
Implement GroupImpl::RemoveAll (81.30%)
madebr Dec 20, 2024
fcc0561
Minor improvement
foxtacles Dec 20, 2024
d25d3bd
Add 2 to total function count
foxtacles Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ jobs:
run: |
reccmp-reccmp -S CONFIGPROGRESS.SVG --svg-icon assets/config.png --target CONFIG | tee CONFIGPROGRESS.TXT
reccmp-reccmp -S ISLEPROGRESS.SVG --svg-icon assets/isle.png --target ISLE | tee ISLEPROGRESS.TXT
reccmp-reccmp -S LEGO1PROGRESS.SVG -T 4352 --svg-icon assets/lego1.png --target LEGO1 | tee LEGO1PROGRESS.TXT
reccmp-reccmp -S LEGO1PROGRESS.SVG -T 4354 --svg-icon assets/lego1.png --target LEGO1 | tee LEGO1PROGRESS.TXT

- name: Compare Accuracy With Current Master
shell: bash
Expand Down
20 changes: 18 additions & 2 deletions LEGO1/tgl/d3drm/group.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,26 @@ Result GroupImpl::Remove(const Group* pGroup)
return ResultVal(m_data->DeleteVisual(pGroupImpl->m_data));
}

// STUB: LEGO1 0x100a34b0
// FUNCTION: LEGO1 0x100a34b0
Result GroupImpl::RemoveAll()
{
return Error;
IDirect3DRMVisualArray* visuals;
IDirect3DRMFrame2* frame = m_data;
Result result = (Result) SUCCEEDED(frame->GetVisuals(&visuals));

if (result == Success) {
for (int i = 0; i < (int) visuals->GetSize(); i++) {
IDirect3DRMVisual* visual;

result = (Result) SUCCEEDED(visuals->GetElement(i, &visual));
frame->DeleteVisual(visual);
visual->Release();
}

visuals->Release();
}

return result;
}

// STUB: LEGO1 0x100a3540
Expand Down
Loading