Implement MxDisplaySurface::VTable0x34#1264
Merged
foxtacles merged 5 commits intoisledecomp:masterfrom Dec 23, 2024
Merged
Conversation
Member
|
Matched it to 100%. Since the function exists in the BETA at address |
madebr
commented
Dec 23, 2024
| } | ||
| case 16: { | ||
| if (p_bpp == 16) { | ||
| MxU8* dst = (MxU8*) surfaceDesc.lpSurface + p_y * surfaceDesc.lPitch + p_x; |
Contributor
Author
There was a problem hiding this comment.
Is this correct if both dest and src contain 16-bit pixels?
Shouldn't it be + 2 * p_x?
Member
There was a problem hiding this comment.
Yes I think you are right. It looks like a bug. The function is never called in the game
Member
|
I was here! Thanks everyone. 🎉 |
Algiuxs
approved these changes
Dec 23, 2024
Ramen2X
approved these changes
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accuracy is an embarrassing 34.91%.
Here's some stack information to get you started:
(It's a "RawBlitAt" function)