Skip to content

SkateBoard: name m_unk0x160 -> m_pizzaVisible#1269

Merged
foxtacles merged 1 commit intoisledecomp:masterfrom
JPeisach:rename-skateboard-m_unk0x160
Dec 24, 2024
Merged

SkateBoard: name m_unk0x160 -> m_pizzaVisible#1269
foxtacles merged 1 commit intoisledecomp:masterfrom
JPeisach:rename-skateboard-m_unk0x160

Conversation

@JPeisach
Copy link
Copy Markdown
Contributor

@JPeisach JPeisach commented Dec 24, 2024

m_unk0x160 is just a boolean for whether the pizza is shown in the hand on the left when skateboarding.

This can easily be tested by setting the value to TRUE in the constructor.

By the way - how should we name variables? This could be m_isPizzaVisible, m_showPizza, m_showingPizza, etc

@foxtacles foxtacles merged commit bb29d28 into isledecomp:master Dec 24, 2024
@foxtacles
Copy link
Copy Markdown
Member

foxtacles commented Dec 24, 2024

By the way - how should we name variables? This could be m_isPizzaVisible, m_showPizza, m_showingPizza, etc

There is not much of a hard rule here other than:

  1. If we can find a name confirmed through the BETA10, this name always takes precedence
  2. Otherwise, naming should be as concise as possible and most importantly, somewhat consistent with other naming in the code. In this case, pizzaVisible seems reasonable to make sure it contains the reference to the pizza, and "visible" is used in several other places already so it's fine.

Other than that, a name must make sense and be verified. "Vague" names are worse than no names (unk style)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants