SkateBoard: name m_unk0x160 -> m_pizzaVisible#1269
Merged
foxtacles merged 1 commit intoisledecomp:masterfrom Dec 24, 2024
Merged
SkateBoard: name m_unk0x160 -> m_pizzaVisible#1269foxtacles merged 1 commit intoisledecomp:masterfrom
foxtacles merged 1 commit intoisledecomp:masterfrom
Conversation
Member
There is not much of a hard rule here other than:
Other than that, a name must make sense and be verified. "Vague" names are worse than no names (unk style) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
m_unk0x160 is just a boolean for whether the pizza is shown in the hand on the left when skateboarding.
This can easily be tested by setting the value to TRUE in the constructor.
By the way - how should we name variables? This could be m_isPizzaVisible, m_showPizza, m_showingPizza, etc