Skip to content

fix: rawpasssize can use int or long long values if the size is too big #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miltoncamacho wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: rawpasssize can use int or long long values if the size is too big #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/GERawConverter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,20 @@ std::string GERawConverter::ge_header_to_xml(GERecon::Legacy::LxDownloadDataPoin
writer.formatElement("ScanCenter", "%f", processingControl->Value<float>("ScanCenter"));
writer.formatElement("Landmark", "%f", processingControl->Value<float>("Landmark"));
writer.formatElement("CoilConfigUID", "%u", processingControl->Value<unsigned int>("CoilConfigUID"));
writer.formatElement("RawPassSize", "%llu", processingControl->Value<int>("RawPassSize"));
try {
// Attempt to use `int` for RawPassSize
writer.formatElement("RawPassSize", "%llu", processingControl->Value<int>("RawPassSize"));
} catch (const std::exception& e) {
std::cerr << "Failed to retrieve RawPassSize as int: " << e.what() << ". Trying unsigned long long instead." << std::endl;
try {
// Fallback to `unsigned long long` if the first attempt fails
writer.formatElement("RawPassSize", "%llu", processingControl->Value<unsigned long long>("RawPassSize"));
} catch (const std::exception& e) {
// If both attempts fail, set a default value and continue
std::cerr << "Failed to retrieve RawPassSize as unsigned long long: " << e.what() << ". Using default value 0." << std::endl;
writer.formatElement("RawPassSize", "%llu", 0ULL); // Default value
}
}

// ReconstructionParameters
writer.addBooleanElement("CreateMagnitudeImages", processingControl->Value<bool>("CreateMagnitudeImages"));
Expand Down