Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Vars: add source destination check variable" #52

Merged
merged 2 commits into from
Jun 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ An opinionated Terraform module that can be used to create and manage an EKS clu
| <a name="input_phlare_bucket_name"></a> [phlare\_bucket\_name](#input\_phlare\_bucket\_name) | The name of the S3 bucket that will be used by Phlare | `string` | `""` | no |
| <a name="input_phlare_oidc_fully_qualified_subjects"></a> [phlare\_oidc\_fully\_qualified\_subjects](#input\_phlare\_oidc\_fully\_qualified\_subjects) | The list of trusted resources which can assume the 'phlare' role using OpenID Connect. | `list(string)` | `[]` | no |
| <a name="input_region"></a> [region](#input\_region) | The region in which to create the EKS cluster. | `string` | n/a | yes |
| <a name="input_self_managed_node_groups"></a> [self\_managed\_node\_groups](#input\_self\_managed\_node\_groups) | A map describing the set of self-managed node groups to create. Other types of node groups besides self-managed are currently not supported. | <pre>map(object({<br> platform = optional(string)<br> ami_name_filter = string<br> extra_tags = map(string)<br> instance_type = string<br> kubelet_extra_args = string<br> max_nodes = number<br> min_nodes = number<br> name = string<br> pre_bootstrap_user_data = string<br> post_bootstrap_user_data = string<br> root_volume_id = string<br> root_volume_size = number<br> root_volume_type = string<br> subnet_ids = list(string)<br> source_dest_check = optional(bool, true)<br> iam_role_additional_policies = map(string)<br> iam_role_use_name_prefix = optional(bool, true)<br> key_name = optional(string)<br> }))</pre> | n/a | yes |
| <a name="input_self_managed_node_groups"></a> [self\_managed\_node\_groups](#input\_self\_managed\_node\_groups) | A map describing the set of self-managed node groups to create. Other types of node groups besides self-managed are currently not supported. | <pre>map(object({<br> platform = optional(string)<br> ami_name_filter = string<br> extra_tags = map(string)<br> instance_type = string<br> kubelet_extra_args = string<br> max_nodes = number<br> min_nodes = number<br> name = string<br> pre_bootstrap_user_data = string<br> post_bootstrap_user_data = string<br> root_volume_id = string<br> root_volume_size = number<br> root_volume_type = string<br> subnet_ids = list(string)<br> iam_role_additional_policies = map(string)<br> iam_role_use_name_prefix = optional(bool, true)<br> key_name = optional(string)<br> }))</pre> | n/a | yes |
| <a name="input_tags"></a> [tags](#input\_tags) | The set of tags to place on the EKS cluster. | `map(string)` | n/a | yes |
| <a name="input_velero_bucket_name"></a> [velero\_bucket\_name](#input\_velero\_bucket\_name) | The name of the S3 bucket that will be used to upload Velero backups. | `string` | `""` | no |
| <a name="input_velero_oidc_fully_qualified_subjects"></a> [velero\_oidc\_fully\_qualified\_subjects](#input\_velero\_oidc\_fully\_qualified\_subjects) | The list of trusted resources which can assume the 'velero' role using OpenID Connect. | `list(string)` | `[]` | no |
Expand Down
7 changes: 3 additions & 4 deletions eks.tf
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,9 @@ module "main" {
iam_role_additional_policies = g.iam_role_additional_policies
iam_role_use_name_prefix = g.iam_role_use_name_prefix
subnet_ids = length(g.subnet_ids) > 0 ? g.subnet_ids : data.aws_subnets.private.ids // Only place nodes in private subnets. This may change in the future.
source_dest_check = g.source_dest_check
tags = merge(g.extra_tags, { // The set of tags placed on each worker node.
"k8s.io/cluster-autoscaler/enabled" = "true", // Required by the cluster autoscaler.
"k8s.io/cluster-autoscaler/${var.name}" = "owned", // Required by the cluster autoscaler.
tags = merge(g.extra_tags, { // The set of tags placed on each worker node.
"k8s.io/cluster-autoscaler/enabled" = "true", // Required by the cluster autoscaler.
"k8s.io/cluster-autoscaler/${var.name}" = "owned", // Required by the cluster autoscaler.
})
block_device_mappings = {
(g.root_volume_id) = {
Expand Down
1 change: 0 additions & 1 deletion variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ variable "self_managed_node_groups" {
root_volume_size = number
root_volume_type = string
subnet_ids = list(string)
source_dest_check = optional(bool, true)
iam_role_additional_policies = map(string)
iam_role_use_name_prefix = optional(bool, true)
key_name = optional(string)
Expand Down