fix: context id may be missing on error responses (#21)

ispras · Sep 11, 2023 · 89d4bf2 · 89d4bf2
1 parent 642d0fb
commit 89d4bf2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/scrapypuppeteer/middleware.py b/scrapypuppeteer/middleware.py
@@ -156,7 +156,9 @@ def process_response(self, request, response, spider):
         response_cls = self._get_response_class(puppeteer_request.action)
 
         if response.status != 200:
-            self.used_contexts[id(spider)].add(response_data['contextId'])
+            context_id = response_data.get('contextId')
+            if context_id:
+                self.used_contexts[id(spider)].add(context_id)
             return response
 
         return self._form_response(response_cls, response_data,

diff --git a/setup.py b/setup.py
@@ -7,7 +7,7 @@
 
 setup(
     name='scrapy-puppeteer-client',
-    version='0.1.3',
+    version='0.1.4',
     description='A library to use Puppeteer-managed browser in Scrapy spiders',
     long_description=long_description,
     long_description_content_type="text/markdown",