Skip to content

Commit

Permalink
Added more support for vertical tables. (#7)
Browse files Browse the repository at this point in the history
* Added feature verticalTable, test tables and correct autofill for Data rows selector

* Added getting header and data raw css for simple tables.

* Fixed header and data row css selector.

* Fixed header and data row css selector.

* Fixed header and data row css selector.

* Some changes of getting data in vertical tables dataCells

* Added DataPreview for vertical Tables

* Added column selection for vertical tables

* Added Data preview and scrape for vertical and horizontal tables without changing Result key

* Added Data preview and scrape for vertical and horizontal tables without changing Result key

* Refactored verticalTable. Now checking doing only in Controller.

* Fixed verticalTable checkbox in SelectorEdit.html

* Fixed a lot of bugs with verticalTable.

* Fixed a lot of bugs of selectorTable, but still have problems with complicated case(table in table)

* Code style changes and moved extraction of selector verticalTable value to getCurrentlyEditedSelector method.
  • Loading branch information
Yatskov authored Feb 21, 2020
1 parent f7e46c6 commit 3af4b3b
Show file tree
Hide file tree
Showing 4 changed files with 1,576 additions and 1,473 deletions.
14 changes: 13 additions & 1 deletion extension/devtools/views/SelectorEdit.html
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,19 @@
<div class="col-sm-8">
<div class="checkbox">
<label>
<input type="checkbox" name="tableAddMissingColumns" {{#selector.tableAddMissingColumns}} checked="checked" {{/selector.tableAddMissingColumns}}>
<input type="checkbox" id="tableAddMissingColumns" name="tableAddMissingColumns" {{#selector.tableAddMissingColumns}} checked="checked" {{/selector.tableAddMissingColumns}}>
</label>
</div>
</div>
</div>

<!-- verticalTable -->
<div class="form-group feature feature-verticalTable">
<label for="verticalTable" class="col-sm-2 control-label">This is vertical table</label>
<div class="col-sm-8">
<div class="checkbox">
<label>
<input type="checkbox" id="verticalTable" name="verticalTable" {{#selector.verticalTable}} checked="checked" {{/selector.verticalTable}}>
</label>
</div>
</div>
Expand Down
Loading

0 comments on commit 3af4b3b

Please sign in to comment.