Skip to content

Commit

Permalink
fix error messages for selector and sitemap ids (#144)
Browse files Browse the repository at this point in the history
  • Loading branch information
mxsnq authored Aug 16, 2024
1 parent 4056d2b commit 9bcf6cd
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 10 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "web-scraper-chrome-extension",
"version": "0.4.13",
"version": "0.4.14",
"description": "Web data extraction tool implemented as chrome extension",
"scripts": {
"lint": "eslint --ext .js src",
Expand Down
6 changes: 6 additions & 0 deletions src/_locales/en/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,12 @@
},
"selecting_file_error": { "message": "Please select a file!" },
"sitemap_valid_message": { "message": "Valid sitemap" },
"selectorid_empty_message": {
"message": "The selector id is required and cannot be empty"
},
"selectorid_short_message": {
"message": "The selector id should be at least 3 characters long"
},
"selectorid_underscore": { "message": "Selector id cannot start with an underscore _" },
"selectorid_is_already_exist": {
"message": "Current selector ID is already exist"
Expand Down
8 changes: 7 additions & 1 deletion src/_locales/ru/messages.json
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@
},
"sitemapid_repeated_id": { "message": "Карта обхода с таким идентификатором уже существует" },
"sitemapid_empty_message": {
"message": "Идентификатор селектора обязателен и не может быть пустым"
"message": "Идентификатор карты обхода обязателен и не может быть пустым"
},
"sitemapurl_empty_message": { "message": "Стартовый URL обязателен и не может быть пустым" },
"sitemapurl_invalid_message": {
Expand All @@ -276,6 +276,12 @@
},
"selecting_file_error": { "message": "Пожалуйста, выберите файл!" },
"sitemap_valid_message": { "message": "Правильная карта обхода" },
"selectorid_empty_message": {
"message": "Идентификатор селектора обязателен и не может быть пустым"
},
"selectorid_short_message": {
"message": "Длина идентификатора селектора должна быть как минимум 3 символа"
},
"selectorid_underscore": {
"message": "Идентификатор не может начинаться с нижнего подчеркивания _"
},
Expand Down
14 changes: 6 additions & 8 deletions src/scripts/Controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ import SelectorTable from './Selector/SelectorTable';
import Model from './Model';
import Translator from './Translator';

export const SITEMAP_ID_REGEXP = /^[a-z][a-z0-9_\$\(\)\+\-]+$/
export const SITEMAP_ID_REGEXP = /^[a-z][a-z0-9_\$\(\)\+\-]+$/;

export default class SitemapController {
constructor(store, templateDir) {
export default class SitemapController {
constructor(store, templateDir) {
this.store = store;
this.templateDir = templateDir;
this.contentScript = getContentScript('DevTools');
Expand Down Expand Up @@ -599,9 +599,7 @@ export default class SitemapController {
),
};
}
if (
!sitemap._id.match(SITEMAP_ID_REGEXP)
) {
if (!sitemap._id.match(SITEMAP_ID_REGEXP)) {
return {
valid: false,
message:
Expand Down Expand Up @@ -1070,11 +1068,11 @@ export default class SitemapController {
id: {
validators: {
notEmpty: {
message: Translator.getTranslationByKey('sitemapid_empty_message'),
message: Translator.getTranslationByKey('selectorid_empty_message'),
},
stringLength: {
min: 3,
message: Translator.getTranslationByKey('sitemapid_short_message'),
message: Translator.getTranslationByKey('selectorid_short_message'),
},
regexp: {
regexp: /^[^_].*$/,
Expand Down

0 comments on commit 9bcf6cd

Please sign in to comment.