MESH-5405-Create prefixed SEs #336
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
August 29, 2024 19:03
…dditional-SE-UnitTests
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #336 +/- ##
==========================================
- Coverage 71.83% 71.02% -0.81%
==========================================
Files 66 66
Lines 9269 9394 +125
==========================================
+ Hits 6658 6672 +14
- Misses 2251 2359 +108
- Partials 360 363 +3 ☔ View full report in Codecov by Sentry. |
Punakshi
commented
Sep 12, 2024
|
Looks good - only thing is that need some comments to explain the service map structure and expectations of state syncer. Meaning, we should only have default and test keys, should only have one service in the array value for the test key, etc. (in getServiceEntryEndpoints) |
added 2 commits
September 16, 2024 12:47
- Changed `testServiceKey` from "canary" to "testSvc" - Enhanced error handling to check for empty endpoints - Added detailed comments explaining service key usage scenarios - Improved logic to handle services with `testServiceKey` in endpoint assignment
# Conflicts: # admiral/pkg/clusters/configwriter.go
rtay1188
approved these changes
Sep 16, 2024
vinay-g
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
🚨 Please review this repository's contribution guidelines.
Description
What does this change do and why?
Handles the canary, bluegreen, deployment to rollout migration
[Link to related ISSUE]
Thank you!