MESH-5405-Create additional SE-State Syncer changes #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
August 29, 2024 19:03
…dditional-SE-UnitTests
Punakshi
changed the title
Punakshi
changed the title
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
==========================================
- Coverage 71.83% 70.94% -0.89%
==========================================
Files 66 66
Lines 9269 9423 +154
==========================================
+ Hits 6658 6685 +27
- Misses 2251 2375 +124
- Partials 360 363 +3 ☔ View full report in Codecov by Sentry. |
added 3 commits
September 16, 2024 12:47
- Changed `testServiceKey` from "canary" to "testSvc" - Enhanced error handling to check for empty endpoints - Added detailed comments explaining service key usage scenarios - Improved logic to handle services with `testServiceKey` in endpoint assignment
# Conflicts: # admiral/pkg/clusters/configwriter.go
# Conflicts: # admiral/pkg/clusters/configwriter.go
rtay1188
approved these changes
Sep 16, 2024
added 2 commits
September 16, 2024 13:15
…5-Create-Additional-SE-StateSyncer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
🚨 Please review this repository's contribution guidelines.
Description
What does this change do and why?
[Link to related ISSUE]
Thank you!