MESH-5878: Admiral does not create envoy filter on client onboardings #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #362 +/- ##
==========================================
+ Coverage 63.25% 63.74% +0.49%
==========================================
Files 91 91
Lines 12158 12218 +60
==========================================
+ Hits 7690 7788 +98
+ Misses 4053 4016 -37
+ Partials 415 414 -1 ☔ View full report in Codecov by Sentry. |
adilfulara
force-pushed
the
MESH-5878
branch
4 times, most recently
from
a538076 to
d2ffc07
Compare
- Introduce RoutingPolicyProcessor interface - Inject RoutingPolicyService into DependencyHandler Tech-Debt: - Increase coverage for routingpolicy_handler.go Signed-off-by: Adil Fulara <[email protected]>
adilfulara
force-pushed
the
MESH-5878
branch
from
d2ffc07 to
d2b5b9b
Compare
- Add unit tests for RoutingPolicyService.DeltaUpdate() api Signed-off-by: Adil Fulara <[email protected]>
- Rename Signed-off-by: Adil Fulara <[email protected]>
- Coverage Signed-off-by: Adil Fulara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Description
What does this change do and why?
Thank you!