Skip to content

Add DNSSettings for Tracer Configuration (API part) #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 58 additions & 1 deletion mesh/v1alpha1/istio.mesh.v1alpha1.pb.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1,104 changes: 604 additions & 500 deletions mesh/v1alpha1/proxy.pb.go

Large diffs are not rendered by default.

23 changes: 21 additions & 2 deletions mesh/v1alpha1/proxy.proto
Original file line number Diff line number Diff line change
@@ -192,6 +192,17 @@ message Tracing {
string default_value = 2;
}

// Configures DNS settings for the tracing service.
message DNSSettings {
// The DNS refresh rate to fetch DNS records for the tracing service.
// Default is 30 seconds.
google.protobuf.Duration refresh_rate = 1;

// Whether to respect DNS TTL values for the tracing service.
// Default is true.
bool respect_ttl = 2;
}

// Configures the custom tags to be added to active span by all proxies (i.e. sidecars
// and gateways).
// The key represents the name of the tag.
@@ -221,9 +232,17 @@ message Tracing {
// mode as `ISTIO_MUTUAL`.
istio.networking.v1alpha3.ClientTLSSettings tls_settings = 8;

// $hide_from_docs
// Next available field number: 10
// Configures DNS settings for the tracing service.
// Ex:
// ```yaml
// dns_settings:
// refresh_rate: 30s
// respect_ttl: true
// ```
DNSSettings dns_settings = 10;

// $hide_from_docs
// Next available field number: 11
}

// SDS defines secret discovery service(SDS) configuration to be used by the proxy.
20 changes: 20 additions & 0 deletions proto.lock
Original file line number Diff line number Diff line change
@@ -38579,6 +38579,11 @@
"id": 8,
"name": "tls_settings",
"type": "istio.networking.v1alpha3.ClientTLSSettings"
},
{
"id": 10,
"name": "dns_settings",
"type": "DNSSettings"
}
],
"maps": [
@@ -38727,6 +38732,21 @@
"type": "string"
}
]
},
{
"name": "DNSSettings",
"fields": [
{
"id": 1,
"name": "refresh_rate",
"type": "google.protobuf.Duration"
},
{
"id": 2,
"name": "respect_ttl",
"type": "bool"
}
]
}
]
},