Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand config profiles doc to mention helm + istioctl usage, and also mention platform profiles #16087

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bleggett
Copy link
Contributor

@bleggett bleggett commented Dec 12, 2024

Description

  • Explicitly mention profiles can be used by helm and istioctl
  • Explain the difference between platform profiles and regular profiles - I have dubbed the latter deployment profiles, better names welcome.

There are still some UX gubbins here I do not like (mostly having to get into the weeds that even though they're directly shared with istioctl, with istioctl they also select specific components, which is not true in our helm impl ATM) - but better to document how it currently works than not.

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

Signed-off-by: Benjamin Leggett <[email protected]>
@bleggett bleggett requested a review from a team as a code owner December 12, 2024 23:34
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 12, 2024
@bleggett bleggett changed the title Expand config profiles stuff to mention they can be used for helm and istioctl, and also mention platform profiles Expand config profiles doc to mention helm + istioctl usage, and also mention platform profiles Dec 12, 2024
Signed-off-by: Benjamin Leggett <[email protected]>
Copy link
Member

@dhawton dhawton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit since it's not being used as a value, it should be used as the name and capitalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/environments kind/docs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants