Skip to content

Conversation

Cam6349
Copy link

@Cam6349 Cam6349 commented Aug 28, 2025

What this PR does / why we need it:

This PR will expose the CEL sampler for otel. We currently do not have a way to drop traces based on certain conditions in the service mesh. We would like to be able to make intelligent tracing decisions in the service mesh instead of having to make multiple changes to all micro services.

Special notes for your reviewer:

@Cam6349 Cam6349 requested a review from a team as a code owner August 28, 2025 14:34
@istio-policy-bot
Copy link

😊 Welcome @Cam6349! This is either your first contribution to the Istio proxy repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

Copy link

CLA Not Signed

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Aug 28, 2025
@istio-testing
Copy link
Collaborator

Hi @Cam6349. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zirain
Copy link
Member

zirain commented Aug 28, 2025

/ok-to-test

please fix CLA

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants