Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add memory leak tests using the snippets in #257 as a starting point.
These take the form of benchmarks that fail on excessive memory usage (determined by an environment variable
MEM_THRESHOLD
), which makes detection simple (just rungo test -bench
) and investigation straightforward using standard Go profiling tools:go test -bench=Leak/select -memprofile leak.prof go tool pprof gojq.test leak.prof
Additionally,
make test
now also runs these tests so that memory leaks can be found by CI. See the failing checks below for details.