Repository navigation
fix: correct versions comparison - #223
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a version comparison issue in the Podkop diagnostic system information widget. The current version was being compared directly against podkop_latest_version, but the comparison was failing because the local version includes a "v" prefix while the latest version from the API does not.
Key Changes:
- Updated version comparison logic to prepend "v" to the latest version string before comparison
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| luci-app-podkop/htdocs/luci-static/resources/view/podkop/main.js | Fixed version comparison by adding "v" prefix to latest version |
| fe-app-podkop/src/podkop/tabs/diagnostic/initController.ts | Fixed version comparison by adding "v" prefix to latest version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
itdoginfo
approved these changes
Oct 23, 2025
Dushnilin
referenced
this pull request
in Dushnilin/tachyon
Jul 17, 2026
fix: correct versions comparison
Screamshow
pushed a commit
to Screamshow/forkop-x
that referenced
this pull request
Sep 3, 2026
fix: correct versions comparison
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.