Repository navigation
Some FE improvements - #224
Merged
Merged
Conversation
divocat
commented
Oct 23, 2025
Collaborator
- Добавлен wiki блок в диагностику
- Остатки по диагностике
- Повышен shell timeout до 15с для слабых устройств
- Кастом порт и путь (для айпи) для dns
- Переводы для проверок диагностики и системных виджетов
- Поправлена proxy link валидация убираем лишние пробелы в конце и разрешены слеши после порта
- На диагностике если не удалось получить глобал чек или конфиг или логи - будет уведомление об ошибке
- Поправлены стили для уведомления о некорректно выбранных списках
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the frontend diagnostics interface and improves various validation functions. The main purpose is to make diagnostic checks more user-friendly by consolidating repetitive messages, adding visual guidance through a wiki troubleshooting widget, and supporting DNS configurations with custom ports and paths.
Key Changes:
- Consolidated diagnostic check messages to reduce translation overhead and improve consistency
- Added a wiki troubleshooting widget that displays based on diagnostic check results
- Enhanced DNS validation to support custom ports and paths (e.g.,
1.1.1.1:853/dns-query) - Improved proxy URL validation to handle trailing whitespace and slashes after ports
- Increased shell command timeout from 10s to 15s for slower devices
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
luci-app-podkop/po/templates/podkop.pot |
Updated translation template with consolidated messages and new troubleshooting strings |
luci-app-podkop/po/ru/podkop.po |
Updated Russian translations matching the template changes |
luci-app-podkop/htdocs/luci-static/resources/view/podkop/section.js |
Removed CSS class from warning notification element |
luci-app-podkop/htdocs/luci-static/resources/view/podkop/main.js |
Bundled JS with all frontend changes including validation improvements |
fe-app-podkop/src/validators/validateVlessUrl.ts |
Added port cleaning to handle trailing slashes in VLESS URLs |
fe-app-podkop/src/validators/validateProxyUrl.ts |
Added URL trimming to handle leading/trailing whitespace |
fe-app-podkop/src/validators/validateDns.ts |
Enhanced to support port and path specifications in DNS addresses |
fe-app-podkop/src/validators/tests/validateDns.test.js |
Added test cases for DNS validation with ports and paths |
fe-app-podkop/src/podkop/tabs/diagnostic/* |
Multiple diagnostic improvements including wiki widget and consolidated check messages |
fe-app-podkop/src/icons/renderBookOpenTextIcon24.ts |
New icon component for the wiki troubleshooting widget |
fe-app-podkop/locales/* |
Updated locale files with new and consolidated translation strings |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Screamshow
pushed a commit
to Screamshow/forkop-x
that referenced
this pull request
Sep 3, 2026
Some FE improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.