Repository navigation
small pack of fixes - #232
Merged
Merged
Conversation
divocat
commented
Oct 26, 2025
divocat
commented
Collaborator
- валидация json outbound упрощена и теперь настройка может быть более гибкой
- потенциальный фикс для старых браузеров с ошибкой structuredClone
- чуть правок по вордингу в переводах
- потенциальный фикс outdated когда actual version приходит некорректно
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR includes several improvements and fixes: simplified JSON outbound validation for more flexible configuration, a polyfill for structuredClone to support older browsers, translation wording improvements, and a fix for incorrect outdated version detection when the actual version is unknown.
- Simplified outbound JSON validation by removing required field checks
- Added
structuredClonepolyfill for older browser compatibility - Fixed version comparison logic to handle "unknown" actual version
- Updated translation files to reflect changes
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| fe-app-podkop/src/validators/validateOutboundJson.ts | Removed specific field validation, now only validates JSON syntax |
| fe-app-podkop/src/podkop/tabs/diagnostic/initController.ts | Added check to exclude "unknown" string when determining if actual version exists |
| fe-app-podkop/src/main.ts | Added polyfill for structuredClone function for older browsers |
| luci-app-podkop/htdocs/luci-static/resources/view/podkop/main.js | Compiled JavaScript with the TypeScript changes applied |
| luci-app-podkop/htdocs/luci-static/resources/view/podkop/settings.js | Updated translation key reference |
| luci-app-podkop/po/templates/podkop.pot | Updated translation template with removed entries and updated line references |
| luci-app-podkop/po/ru/podkop.po | Updated Russian translations with removed entries |
| fe-app-podkop/locales/podkop.pot | Updated translation template with removed entries and updated line references |
| fe-app-podkop/locales/podkop.ru.po | Updated Russian translations with removed entries |
| fe-app-podkop/locales/calls.json | Updated translation call references and line numbers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
itdoginfo
approved these changes
Oct 26, 2025
Screamshow
pushed a commit
to Screamshow/forkop-x
that referenced
this pull request
Sep 3, 2026
…und_validation small pack of fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.