Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in packet marking by introducing non-overlapping mark values and a proper mask. The old mark values (0x80000 and 0x90000) had overlapping bits that could cause conflicts in packet routing decisions. The new values (0x00010000 and 0x00020000) are mutually exclusive with a proper mask (0x00030000) for bitwise operations.
Changes:
- Updated mark constants to non-overlapping values
- Introduced NFT_MARK_MASK for proper bitwise operations
- Updated all ip rule and nftables commands to use the new mask
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| podkop/files/usr/lib/constants.sh | Updated NFT_FAKEIP_MARK and NFT_OUTBOUND_MARK to non-overlapping values, added NFT_MARK_MASK |
| podkop/files/usr/bin/podkop | Updated ip rule and nftables commands to use new NFT_MARK_MASK for consistent packet marking logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
itdoginfo
force-pushed
the
firewall-new-mark
branch
from
1283590 to
2cce383
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание изменений
Новая маркиврока чтоб не было конфликтов