feat(diagnostic): stringify sb config json#304
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the diagnostic tab where the sing-box configuration was not being properly displayed. The backend returns a JSON object which needs to be stringified before being passed to the modal renderer.
Changes:
- Added
JSON.stringify()to format the sing-box config data before displaying it in a modal - Removed incorrect type assertion
as stringin the TypeScript version
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
luci-app-podkop/htdocs/luci-static/resources/view/podkop/main.js |
Wraps showSingBoxConfig.data with JSON.stringify() to properly format the JSON object for display |
fe-app-podkop/src/podkop/tabs/diagnostic/initController.ts |
Same as above, also removes incorrect as string type assertion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
itdoginfo
approved these changes
Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание изменений
Краткое описание ваших изменений и их цель.
Что изменено
Детальное описание изменений:
(Этим вы экономите время ревьювера)