Fixing np array dumping #599
Open
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
==========================================
- Coverage 87.88% 87.87% -0.01%
==========================================
Files 100 100
Lines 10011 10015 +4
Branches 1357 1358 +1
==========================================
+ Hits 8798 8801 +3
Misses 871 871
- Partials 342 343 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Deploying datachain-documentation with
|
| Latest commit: |
41cddc2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://444ca950.datachain-documentation.pages.dev |
| Branch Preview URL: | https://ilongin-598-fix-np-array-dum.datachain-documentation.pages.dev |
skshetry
reviewed
Nov 14, 2024
src/datachain/sql/sqlite/types.py
Outdated
Comment on lines
45
to
47
| if np.issubdtype(arr.dtype, np.object_): | ||
| # orjson cannot parse arrays with object subtype | ||
| return json.dumps(arr.tolist(), default=_json_serialize) |
There was a problem hiding this comment.
orjson also supports default=.... See https://github.com/ijl/orjson#default.
There was a problem hiding this comment.
Tnx, added it instead using json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for dumping np array into SQLite as current json lib doesn't work well with the object type np arrays