tickets views #1158
tickets views #1158
Conversation
Kanban view Compact view
sync last changes on days 27 and 28
tickets.php
Outdated
|
|
||
| ?> | ||
| if ($_GET["view"]) { |
There was a problem hiding this comment.
Warning: Undefined array key "view" in tickets.php on line 358
This too.
Also, for the most part we do PHP logic at the very top of the page, unless it makes good sense to do otherwise
There was a problem hiding this comment.
Yes, indeed. but in this case that tickets.php being modular, I couldnt see a simpler way. In the future we can change this
There was a problem hiding this comment.
Lets keep like this for now. Later we can think a better way to do this?
post/user/ticket_kanban.php
Outdated
| continue; | ||
| } | ||
|
|
||
| mysqli_query($mysqli, "UPDATE tickets SET ticket_kanban = $kanban, ticket_status = $status WHERE ticket_id = $ticket_id"); |
There was a problem hiding this comment.
Resolved tickets should be setting ticket_resolved_at, and un-resolving a ticket should unset it.
If $config_ticket_client_general_notifications is enabled, we should be sending the contact & any watchers an email to say it's resolved.
There was a problem hiding this comment.
- Resolved tickets should be setting ticket_resolved_at, and un-resolving a ticket should unset it.
- If $config_ticket_client_general_notifications is enabled, we should be sending the contact & any watchers an email to say it's resolved.
There was a problem hiding this comment.
What do you sugest to have the notifications? As I see theres no function to do so, its all coded in ticket posts. The way I see now is to duplicate codes in ajax.php
|
Hey! This is some really nice work here, well done!! I've left a couple comments for you to look over. Generally speaking, I think we should exclude 'Closed' being a state on the board. I'm fine with resolved, but our stance with a ticket being closed is that you don't get to re-open it afterwards. Currently, the kanban bypasses the resolved -> closed flow and also lets you re-open tickets. Also, I'm thinking we should remove the ability to move columns around and rename Thoughts? :) |
I agree with you I did changes now to keep resolved rules that you mentioned, so Resolved will remain on columns |
|
"t probably also makes sense to hide the Kanban option when you are just viewing closed tickets (tickets.php?status=Closed) as you can't do anything with them." About this, makes all sense, will update to behave like that Done |
|
Kanban view
Compact view