Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beginning of the translation with the lang() function #1159

Open
wants to merge 35 commits into
base: develop
Choose a base branch
from

Conversation

Fr3ak88
Copy link

@Fr3ak88 Fr3ak88 commented Jan 30, 2025

Beginning of the translation with the lang() function.

Three new files added.
lang.php represents the translation function.
en.php variables in English language
de.php variables in German language

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello & Welcome! :)

Thanks for taking the time to help improve ITFlow. We're excited to review your contributions - we'll review this PR as soon as we can!

Whilst you're waiting, please feel free to check out the forum.

Just so you know, all contributions to ITFlow are licensed under the GNU GPL. By contributing you grant us a perpetual & irrevocable license to include your work in ITFlow.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@wrongecho wrongecho changed the base branch from master to develop January 30, 2025 19:32
@wrongecho
Copy link
Collaborator

Hey & Welcome!

Is there a reason you're not using gettext for this as suggested in the forum?
It seems there are some advantages over a standard array, the main being that if we don't define a translation for _('something in english'), it just prints 'something in english' rather than a blank space.

See:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants