docs: enhance wallet API documentation and gas limit explanations #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VolodymyrBg
commented
Feb 1, 2025
VolodymyrBg
commented
- Added comprehensive documentation for OdysseyWalletApi trait including:
- Detailed transaction requirements
- Error codes with descriptions
- Usage examples with valid/invalid transactions
- Error recovery guidelines
- Enhanced MAX_SPONSORED_TX_GAS documentation with:
- Explanation of the 350,000 gas limit
- Common operations within the limit
- Operations that exceed the limit
- Mitigation strategies for high-gas transactions
- Added comprehensive documentation for OdysseyWalletApi trait including: - Detailed transaction requirements - Error codes with descriptions - Usage examples with valid/invalid transactions - Error recovery guidelines - Enhanced MAX_SPONSORED_TX_GAS documentation with: - Explanation of the 350,000 gas limit - Common operations within the limit - Operations that exceed the limit - Mitigation strategies for high-gas transactions
VolodymyrBg
requested review from
onbjerg,
Rjected and
mattsse
as code owners
onbjerg
requested changes
Feb 3, 2025
|
@onbjerg Corrected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.