Skip to content

build(deps): Upgrade reth version 1.3.8 => 1.3.12 and alloy version 0.13 => 0.15#163

Merged
RomanHodulak merged 4 commits intomainfrom
deps
Apr 28, 2025
Merged

build(deps): Upgrade reth version 1.3.8 => 1.3.12 and alloy version 0.13 => 0.15#163
RomanHodulak merged 4 commits intomainfrom
deps

Conversation

@RomanHodulak
Copy link
Copy Markdown
Contributor

@RomanHodulak RomanHodulak commented Apr 28, 2025

Closes #162

Bumps all the reth and alloy dependencies to latest.

Note the change in genesis configuration.

The Isthmus maps to Prague hardfork, previously activated by the prague timestamp only
Copy link
Copy Markdown
Contributor

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l g t m :shipit:

Copy link
Copy Markdown
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, the diff is actually not too bad

I believe the failing e2e is now just because of some isthmus specific thing

likely just need to update kurtosis I think

will check

Comment thread .github/workflows/e2e.yml
REPLICA_EL_PORT=$(curl "http://127.0.0.1:9779/api/enclaves/$ENCLAVE_ID/services" | jq '."op-el-2-op-reth-op-node-op-kurtosis".public_ports.rpc.number')
SEQUENCER_EL_PORT=$(curl "http://127.0.0.1:9779/api/enclaves/$ENCLAVE_ID/services" | jq '."op-el-41144114-1-op-reth-op-node-op-kurtosis".public_ports.rpc.number')
curl "http://127.0.0.1:9779/api/enclaves/$ENCLAVE_ID/services" | jq '.'
REPLICA_EL_PORT=$(curl "http://127.0.0.1:9779/api/enclaves/$ENCLAVE_ID/services" | jq '."op-el-41144114-2-op-reth-op-node-op-kurtosis".public_ports.rpc.number')
Copy link
Copy Markdown
Member

@mattsse mattsse Apr 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curios, where do we get this identifier op-el-41144114 from

similar thing here

https://github.com/paradigmxyz/reth/blob/eda2b09132ea761485326c9c810a837f126dfdd7/.github/workflows/kurtosis-op.yml#L67-L68

and not obvious where this is coming from

maybe @fgimenez knows?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe @fgimenez knows?

@mattsse sorry for the late response, yep it comes from the network id as defined in kurtosis args file

network_id: "41144114"

the id used in reth comes from the defaults in optimism kurtosis package https://github.com/ethpandaops/optimism-package/blob/e1d26204bcdb3f5bebc59a76b5f8aba566bcdb13/src/package_io/input_parser.star#L543

@RomanHodulak RomanHodulak merged commit 876b574 into main Apr 28, 2025
14 checks passed
@RomanHodulak RomanHodulak deleted the deps branch April 28, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump to latest reth

4 participants