Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ability to Configure Local Domains in Clockwork Settings #699

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bizon-dot
Copy link

@bizon-dot bizon-dot commented Apr 20, 2024

Hello Team,

This pull request addresses a limitation in Clockwork where the domains considered as ‘local’ were hard-coded. This enhancement introduces configurable local domains, allowing Clockwork to be more adaptable to various development environments.

Problem:

Previously, the domains that Clockwork recognized as local were fixed, making it less flexible for developers working with different or multiple domains during local development.

Solution:

I've introduced a local_domains configuration array in the Clockwork configuration file. Developers can now specify which domains should be considered local by editing this array. If local_domains is not defined, Clockwork will default to the original hardcoded array.

Changes Made:

  • Added a new local_domains array to the Clockwork configuration file.
  • Modified the hasLocalHost() function to utilize the local_domains array instead of the previously hard-coded values.

@itsgoingd
Copy link
Owner

Hey, thanks for the pull request, but I'm not sure if these need to be configurable. If you want to use Clockwork on a non-default local domain, you can always explicitly enable it with CLOCKWORK_ENABLE=true. Or am I missing some use-case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants