-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async for issue #11 #51
Conversation
Adding asynchonous mode
Interchanged playwright and playwright-stealth in order of installation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code itself looks good to me. I'm happy to merge this in, see if the tests work as expected, and then push to PyPi.
Does it make sense for this to a major version bump? i.e. from 0.3.X to 0.4.X because of the async support
I'd think so. Especially since the option strategies would be released with this version as well. |
Correcting typo and adding robustness
I am also experiencing login issues today.
EDIT: had to change: |
changed .*app/trade.* to re.compile(r"app/trade")
Hi Jafer, |
Are you not able to merge this in? I thought once I approve the PR, it can be merged |
Hi itsjafer,
You mentioned code readability as the main issue and not wanting to support sync & async simultaneously.
My initial thought was to to cancel the pull request but I then realized it was pretty straight forward to go fully async.
This will solve issue #11 and is backwards compatible.
I ran this code on streamlit which is incompatible with sync and also tested it with github actions to make sure async works. (cf. test.yml under workflows).