Async for issue #11

[4rumprom]

Hi itsjafer,

You mentioned code readability as the main issue and not wanting to support sync & async simultaneously.
My initial thought was to to cancel the pull request but I then realized it was pretty straight forward to go fully async.

This will solve issue #11 and is backwards compatible.

I ran this code on streamlit which is incompatible with sync and also tested it with github actions to make sure async works. (cf. test.yml under workflows).

[itsjafer]

The code itself looks good to me. I'm happy to merge this in, see if the tests work as expected, and then push to PyPi.

Does it make sense for this to a major version bump? i.e. from 0.3.X to 0.4.X because of the async support

[4rumprom]

Does it make sense for this to a major version bump? i.e. from 0.3.X to 0.4.X because of the async support

I'd think so. Especially since the option strategies would be released with this version as well.

[4rumprom]

I am also experiencing login issues today.
It seems that the url to place trades has changed, at least on my end.
I have made a change to the login to ensure more robustness by looking for the keywords "app/trade" in the url instead of an exact url.

await self.page.wait_for_url(".*app/trade.*") # Making it more robust than specifying an exact url which may change.

EDIT: had to change:
await self.page.wait_for_url(".*app/trade.*") # Making it more robust than specifying an exact url which may change.
to
await self.page.wait_for_url(re.compile(r"app/trade"), wait_until="domcontentloaded") # Making it more robust than specifying an exact url which may change.

[4rumprom]

Hi Jafer,
Is there something missing on my end to complete this?
Tks,
Romain

[itsjafer]

Are you not able to merge this in? I thought once I approve the PR, it can be merged

[4rumprom]

Not 100% sure. This is all pretty new to me.
It does say that only those with write access to this repository can merge pull requests.