Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant code #57

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

tristanpenman
Copy link
Contributor

It appears that limit_price_warning is never defined inside option_trade_v2, so these two lines are no longer required. I only noticed this because VSCode highlighted those lines with a warning.

I'm not familiar enough with the Schwab API to know whether a more correct solution would be to check the validity of the limit price, as in trade_v2. Happy to give that a go if you think that would be better.

@4rumprom
Copy link
Contributor

Yes, I just tried to actually place an order with dry_run=False and noticed this error. It is a copy paste error from the function trade_v2 which was used as a template.

@itsjafer itsjafer merged commit 4ec4d91 into itsjafer:main Mar 25, 2024
1 check passed
@tristanpenman tristanpenman deleted the remove-redundant-code branch March 25, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants