Disable stealth options which block login iframe #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this fixed the problem for me as well (though I have to use firefox as webkit is giving a ValueError: Only supported browserType is 'firefox' on my mac) |
|
hi @NelsonDane, just checking in -- is this change still necessary? |
|
From my testing, I've found it is still necessary, and it has been working well for me and my users in my main project. It also seems to be the fix according to #63 (comment), so I would welcome your thoughts/review :) |
itsjafer
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
On the main page, the iframe that was used for logging in was being blocked by the default stealth options. I went through each option and found the culprits and disabled them. This allows the iframe to show up while still keeping the other stealth options that allow logging in.
Would love a review, or if you have other thoughts, please let me know @itsjafer, but this fixes it for me.