Update logos and favicon assets - #132
Conversation
- Replace text-based brand marks with PNG logos - Add PNG favicons and Apple touch icons
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e20e73d3bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Replace the app and landing-page text marks with the supplied Diffsplain logo. Add 16px and 32px PNG favicons and a 180px Apple touch icon. Keep the warm paper and muted blue palette, which fits the new mark.
The review fix in
f8ae0daexports both Apple touch icons on solid#e9e2d5. Both are opaque 180×180 PNGs with matching bytes. Browser favicons keep their transparency. This follows the Apple touch icon guidance.Verification
Final head
f8ae0da952bb728275f725ec969e9a0a7f8418e4ont3code/update-logo-favicon-colors, based onmain. This is one PR with no linked issue.corepack pnpm run lintandcorepack pnpm run buildpassed for the final code and assets.node --test tests/landing-demo.test.mjspassed all five tests before the two-icon correction.corepack pnpm testdid not pass locally before or after the correction. With Git signing disabled for test fixtures, 202 of 203 unit tests passed. The unchanged provider timeout test attests/review-chat.test.mjs:420failed becauseprovider.pidwas not written. It also failed in isolation. A disposable provider startup probe took 707ms, longer than that test's 500ms deadline.UI proof
Fresh captures from the clean final head above. Launch command:
corepack pnpm run dev --host 127.0.0.1 --port 2302. These are the actual app and landing-page routes with the bundled demo. No browser errors were reported.At
http://127.0.0.1:2302/, the header logo loaded at 1440×900 and the review controls rendered.At
http://127.0.0.1:2302/site/index.html, the logo and navigation remained visible at 390×844.Fetched
/apple-touch-icon.pngand/site/apple-touch-icon.pngfrom that server and checked both PNGs. This image shows the corrected export; it is not an iOS Home Screen capture.Delivery status
The final watcher snapshot reports green CI, no conflicts, and zero unresolved threads. Codex reviewed f8ae0da and found no major issues. One review finding was fixed, none were dismissed, and one fix/push round was used. UI proof above covers the final head.
The local provider-timeout failure remains a limit on the full jdawg readiness claim. The PR has not been merged.