Skip to content

Streamline release verification and consolidate test coverage - #134

Merged
itsjling merged 6 commits into
mainfrom
t3code/investigate-slow-publish-verification
Sep 5, 2026
Merged

Streamline release verification and consolidate test coverage#134
itsjling merged 6 commits into
mainfrom
t3code/investigate-slow-publish-verification

Conversation

@itsjling

@itsjling itsjling commented Sep 5, 2026

Copy link
Copy Markdown
Owner

Reduce repeated verification work while keeping the existing coverage thresholds and browser journeys. Release verification skips docs and publishes the exact tarball that passed its package smoke test.

The full test command collects coverage during one unit and integration pass. Live-update benchmarks remain manual. Direct unit tests now cover note-output limits, with key CLI cases retained. Redundant UI source-text assertions are removed.

Merge main while keeping the deleted source-text test removed. Move the existing Fallow baseline counts with the extracted validators, without increasing the total allowance. Control the provider test deadline after child readiness to remove its startup race. Run Product gate once on Node 24.20.0, the latest LTS when pinned, instead of repeating it for Node 22 and 24. Keep the exact version fixed until an explicit update.

Validation:

  • corepack pnpm run lint at 5543f3a8004859f03cf6cb6c9099e1c72b5a525f
  • GIT_CONFIG_GLOBAL=/dev/null corepack pnpm test at 5543f3a8004859f03cf6cb6c9099e1c72b5a525f
  • GIT_CONFIG_GLOBAL=/dev/null corepack pnpm run check at e2f912c4e5703ef8387245998e7b5ee39898becc, before replacing the LTS alias with an exact pin (includes docs checks/build and package smoke)

Local tests exclude personal Git settings.

Measured cost before the exact-version pin:

Work Before After Change
Test-lane runner time 8m54s 5m56s 2m58s less (33%)
Slowest test lane 3m34s 3m42s 8s longer
Product gate runner time (single-LTS follow-up) 5m19s 2m42s 2m37s less (49%)

These are observed runs, not a controlled benchmark. Test lanes: before, after. Product gate: two versions, latest LTS only. Parallel job removal cuts runner use; these runs do not show a shorter overall CI wait.

The last release's docs stages and second build/package smoke took about 25s combined. Removing them projects its 2m42s prepare/verify step to about 2m17s, before test savings. This is stage subtraction from the prior release, not a newly measured release.

- Skip docs during release checks
- Reuse the verified tarball without rebuilding
- Run core tests once under coverage
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-05T14:24:55.943888Z 5543f3a Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@itsjling

itsjling commented Sep 5, 2026

Copy link
Copy Markdown
Owner Author

@codex review

Review the resolved head 606668e after merging main.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 606668ed62

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@itsjling

itsjling commented Sep 5, 2026

Copy link
Copy Markdown
Owner Author

@codex review

Review final head 212ad2a, including the moved Fallow baseline and controlled provider timeout test.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 212ad2a50c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@itsjling

itsjling commented Sep 5, 2026

Copy link
Copy Markdown
Owner Author

@codex review

Review final head e2f912c, which runs Product gate once on the latest Node LTS and updates its workflow test.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: e2f912c4e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@itsjling

itsjling commented Sep 5, 2026

Copy link
Copy Markdown
Owner Author

@codex review

Review final head 5543f3a, which replaces the floating LTS alias with the exact Node 24.20.0 pin.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 5543f3a800

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@itsjling
itsjling merged commit c010b4c into main Sep 5, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant