Reduce core coverage artifact size and retention - #135
Merged
Conversation
itsjling
marked this pull request as ready for review
September 5, 2026 14:52
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core-coverage upload included raw coverage data in
tmp/; the audit found 108 artifacts using about 4.20 GiB, with the latest ZIP at 61.7 MB.Upload only
coverage/lcov-report/,coverage/lcov.info, andcoverage/coverage-summary.json, and setretention-days: 7. Keepif: always()so failed checks still upload reports, and keepif-no-files-found: error.Existing artifacts keep their original expiry dates. This change applies to future uploads and deletes no existing artifacts. Coverage thresholds, test selection, release artifacts, other workflows, and repository-wide retention remain unchanged.
Validation:
corepack pnpm run setupandcorepack pnpm run lintpassed.corepack pnpm testpassed, including coverage, browser, and platform checks. Coverage produced all three requested paths and met the existing thresholds.node --test tests/test-lanes.test.mjspassed all four tests;git diff --checkpassed.tmp/. The selected reports totalled 899,867 bytes across 16 files.tmp/entries. This is a local measurement; the GitHub artifact ZIP may differ slightly.corepack pnpm run checkpassed lint and build, then stopped with 367/368 tests passing:rebuilds a checkout review when a provider sees a worktree editfailed with ENOENT for a temporarydiff-data.json. It passed in the coverage suite and on an isolated rerun. A second full check run on the same head, without the coverage suite running alongside it, repeated the same failure with 367/368 tests passing. The cause remains unconfirmed. Later check stages did not run. CI Product gate passed, but this local full-check failure remains unresolved.CI artifact verification at
ca3afc48ea6ea83a6e90817639a8624507cf69de:9971517270, sized 151,039 bytes, about 148 KiB. Downloaded the ZIP and verified its integrity and all 16 entries. It contains only the requested reports, totalling 899,421 bytes unpacked.2026-09-05T14:53:34Zand expiry at2026-09-12T14:53:33Z, confirming seven-day retention. Existing artifacts keep their original expiry dates.