Skip to content

Keep established reviews alive during remote outages - #141

Merged
itsjling merged 2 commits into
mainfrom
t3code/triage-issue-140
Sep 8, 2026
Merged

Keep established reviews alive during remote outages#141
itsjling merged 2 commits into
mainfrom
t3code/triage-issue-140

Conversation

@itsjling

@itsjling itsjling commented Sep 8, 2026

Copy link
Copy Markdown
Owner

A connection failure during remote refresh currently stops the watcher, local server, and active agent even after a Review is usable. Keep the last valid Snapshot available, report that it has not refreshed, and retry on the existing remote refresh cadence. Recovery resumes normal updates without regenerating notes for an unchanged target.

The change classifies connection failures from Git fetch, remote default-branch lookup, and GitHub PR metadata lookup. HTTP 500, 502, 503, and 504 responses are also retried. Startup failures and permanent target errors still exit nonzero.

Regression coverage uses local remotes and fake providers to exercise repeated outages, unchanged and changed targets after recovery, HTTP availability, completed notes, in-flight agent completion, and shutdown. The recovery tests failed before the fixes, including Git and GitHub CLI HTTP 500 responses.

Validation: pnpm run lint, pnpm test, and pnpm exec fallow audit --changed-since origin/main.

Fixes #140

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T00:44:33.481524Z fdc1a51 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a3797bd61c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/build-diff-data.mjs Outdated
@itsjling

itsjling commented Sep 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: fdc1a51020

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@itsjling
itsjling merged commit c12c3b3 into main Sep 8, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Could not fetch remote target even though agent notes were generated successfully

1 participant