Skip to content

Test dependency behavior and preserve usage during review refresh - #161

Merged
itsjling merged 4 commits into
mainfrom
fix/behavior-based-dependency-tests
Sep 19, 2026
Merged

itsjling merged 4 commits into
mainfrom
fix/behavior-based-dependency-tests

Conversation

@itsjling

@itsjling itsjling commented Sep 19, 2026

Copy link
Copy Markdown
Owner

Dependency updates failed CI because workflow tests required specific action versions and the image test loaded a private Blume dependency. The tests now check setup order, caching, release safeguards, and Blume's public image audit. The audit checks valid image dimensions and bounds malformed-image processing with a timeout.

The full suite also exposed a Review refresh bug. A raw Snapshot could reset Agent usage after a call finished. Refresh now preserves session usage and the newer Agent notes while still accepting fresh repository metadata. Note timestamps and completion state prevent an older raw Snapshot from replacing work that finished during the refresh. Regression checks force a stale raw refresh to finish after an Agent note, cover remote outages, and check usage reset when a new Review reuses cached Agent notes.

Validation:

  • pnpm test: all 411 tests pass, including coverage, browser, and platform checks.
  • pnpm run lint and pnpm run docs:check: pass.
  • Clean worktree at this commit: CI=true corepack pnpm run setup and CI=true corepack pnpm run check pass.
  • Focused image audit passes with Blume 1.6.4 and 1.7.0.
  • Workflow tests accept new version tags and commit SHAs, reject floating release refs and npm ranges, and still reject incorrect cache settings.

Related dependency PRs: #157, #158, #159, #160.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 19, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-19T06:23:19.407084Z f8c2c1f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2edb487b1a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/release-workflow.test.mjs Outdated
@itsjling

Copy link
Copy Markdown
Owner Author

@codex review

Please review the updated head fed55c2a0147d74c56db5c854dc46d5f68222105. This batch fixes the release-ref finding and preserves newer Agent notes during raw Snapshot refresh. The full suite passes all 411 tests; clean-checkout checks pass.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: fed55c2a01

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@itsjling

Copy link
Copy Markdown
Owner Author

@codex review

Please review final head f8c2c1f8a2e6e4256178ad4c6289d0db10d25326. The only change since your clean review splits note selection and field copying into smaller functions to pass the changed-code complexity audit. All 411 tests, coverage, lint, clean-checkout checks, and the changed-code audit pass locally.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: f8c2c1f8a2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@itsjling
itsjling merged commit 28501fa into main Sep 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant