Skip to content

Make cached review state bounded and concurrency-safe - #65

Merged
itsjling merged 3 commits into
mainfrom
codex/issue-034-cache-concurrency
Jul 31, 2026
Merged

Make cached review state bounded and concurrency-safe#65
itsjling merged 3 commits into
mainfrom
codex/issue-034-cache-concurrency

Conversation

@itsjling

@itsjling itsjling commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

Closes #34

Summary

  • fence note writes with leases so an old writer cannot replace newer notes
  • keep live same-host leases active, recover stale leases, and report first-run activity
  • add cache status, age and size pruning, and explicit safe clearing
  • keep note and lock files private and exclude them from the reviewed diff

Stack

Verification

  • npm run lint
  • npm test — 83 passed
  • npm run docs:check
  • npm run docs:build
  • npm run fallow:audit -- --changed-since origin/codex/issue-019-note-provenance

Stack

  1. Keep review notes outside target repos #43
  2. Make cached review state bounded and concurrency-safe #65 👈 current
  3. Create safe diagnostic records for failed reviews #68

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 30, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a86c399602

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/cache.mjs Outdated
Comment thread scripts/generate-summaries.mjs Outdated
@itsjling itsjling mentioned this pull request Jul 30, 2026
Merged
@itsjling
itsjling force-pushed the codex/issue-034-cache-concurrency branch from a86c399 to c15bf01 Compare July 30, 2026 18:44
@itsjling

itsjling commented Jul 30, 2026

Copy link
Copy Markdown
Owner Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jul 30, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c15bf01f91

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/build-diff-data.mjs Outdated
Comment thread scripts/cache.mjs Outdated
@itsjling
itsjling force-pushed the codex/issue-034-cache-concurrency branch from c15bf01 to 61ecce8 Compare July 30, 2026 18:53
@itsjling
itsjling changed the base branch from codex/issue-019-note-provenance to main July 31, 2026 03:38
@itsjling
itsjling merged commit 1f39da2 into main Jul 31, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make cached review state bounded and concurrency-safe

1 participant

@itsjling