Skip to content

Commit

Permalink
Updates for CRAN
Browse files Browse the repository at this point in the history
  • Loading branch information
Robinlovelace committed Dec 5, 2022
1 parent f99d895 commit 9bf713d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# pct 0.9.7

- Additional changes for CRAN (#222)
- Message rather than error if resource unavailable (#222)

# pct 0.9.6

- Updates to fail gracefully (#220)
Expand Down
6 changes: 4 additions & 2 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
Updates to make the package fail gracefully.

I have updated all functions that download files or that read directly from web URLs to check if the endpoint is 'alive'.
Additional checks for online resources, including the readRDS(url(...)) command this time.
When web resources are unavailable package functions produce a message not an error now, in response to feedback from CRAN (many thanks).


I've tested the package on a laptop with wifi switched off to ensure that the results fail gracefully and indeed they do, e.g., this happens when the user is offline now:

pct::get_pct_zones("west-yorkshire")
Expand Down

0 comments on commit 9bf713d

Please sign in to comment.