Skip to content

utils: Try to fix more JSON errors with JSON5 lib #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2025
Merged

utils: Try to fix more JSON errors with JSON5 lib #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { cache } from './cache.js';
import * as htmlUtils from './html-utils.js';
import log from '../logging.js';
import { resolve } from 'url';
import JSON5 from 'json5';

import CONFIG from '../config.loader.js';

Expand Down Expand Up @@ -343,6 +344,12 @@ export function parseJSONSource(text, decode) {
// default parser failed. Let's try to forgive
}

try {
return JSON5.parse(decode ? entities.decodeHTML(decode(text)) : entities.decodeHTML(text));
} catch (ex) {
// parser failed. Let's try to forgive more
}

var s = text;

// replace opening ( and closing )
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"htmlparser2": "^7.2.0",
"iconv-lite": "^0.6.3",
"jslint": "^0.12.1",
"json5": "^2.2.3",
"jsontoxml": "^1.0.1",
"memcached": "2.2.2",
"moment": "^2.30.1",
Expand Down