Update bedrock-entry.sh to clean up old settings

[brendonthiede]

Setting white-list to true with no whitelist.json file causes all players to show up as not invited. If this container was ran with a version prior to https://github.com/itzg/docker-minecraft-bedrock-server/pull/337/files using an allow/white list, white-list=true would be set in server.properties in the Docker volume, but PR 337 removed the whitelist.json file.

[brendonthiede]

This may be a rare occurrence, but I had previously used WHITE_LIST_USERS in my docker-compose.yml to configure the invited players. The latest bedrock-entry.sh completely removes the deprecated whitelist.json usage in favor of the allowlist.json, but since I'd used the whitelist.json in the past there were traces of that configuration left behind in the data volume. This PR would remove the remaining "whitelist" configuration and only leave the "allowlist".

[itzg]

Thank you! I had flipped between iterations of that and left the old bits behind in the process.

[ijbaird]

This appears to break allow lists by adding the extraneous white-list = 'false' to the bottom of server.properties (for me).

[itzg]

I thought the bug in Bedrock was only triggered by the presence of the whitelist file. So, @ijbaird you're observing that just the property being present breaks it too?

If that's the case, then the set-property tool will need to be enhanced to support removal of properties and not just updating/adding.

[ijbaird]

I thought the bug in Bedrock was only triggered by the presence of the whitelist file. So, @ijbaird you're observing that just the property being present breaks it too?

If that's the case, then the set-property tool will need to be enhanced to support removal of properties and not just updating/adding.

Yes, I'm seeing that the presence of the property setting is enough to trigger the bug.

[ostat]

Yes, I'm seeing that the presence of the property setting is enough to trigger the bug.
This seems similar for us.

I followed this issue #336, and was not able to solve the issue.
Our docker container was still using WHITE_LIST_USERS
To get it working again,

In the docker-compose files we have this.

    environment:
      #ALLOW_LIST: "true"
      ALLOW_LIST_USERS: "name1,name2..."

I deleted the allowlist.json, a new one was generated but there are still no xuid values.

In file server.properties around like 37 we had white-list=false and at the end at line 115 we had allow-list=true. I commented out the white-list=false and restarted the container. white-list=false was added to the end of the file but I can now log on to the server.