Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added user-agent parameter to enable download from minecraft.net. #463

Closed
wants to merge 1 commit into from

Conversation

teedog
Copy link

@teedog teedog commented Oct 2, 2024

Fix for #461.

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks but this is a duplicate of #459. It's already fixed and image has been pushed.

@@ -111,7 +111,7 @@ if [[ ! -f "bedrock_server-${VERSION}" ]]; then
TMP_ZIP="$TMP_DIR/$(basename "${DOWNLOAD_URL}")"

echo "Downloading Bedrock server version ${VERSION} ..."
if ! curl "${curlArgs[@]}" -o "${TMP_ZIP}" -A "itzg/minecraft-bedrock-server" -fsSL "${DOWNLOAD_URL}"; then
if ! curl "${curlArgs[@]}" -H "user-agent: itzg/docker-minecraft-bedrock-server" -o "${TMP_ZIP}" -A "itzg/minecraft-bedrock-server" -fsSL "${DOWNLOAD_URL}"; then
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -A already sets user agent.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! Will close this PR then.

@teedog teedog closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants